Change cursor to default for read only version #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Sam, Thank you for pointing out the bug, but the change should be in |
|
I need to fix couple of typos, i will push 'em with the changes you suggested and change the version to Its mid night for me now :) |
|
Thanks Prrashi! |
|
@sammydigits i just pushed the code with your suggested changes, also i changed the return value after setting an option to a jQuery node to support chaining. I will test the code end to end, and release v1.2.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user attempts to click on a read-only version of the stars, the cursor:pointer still displays even when the stars are not clickable. This pull request fixes that.